It really does depend on your budget and what you want to shoot. I have gathered a reasonable collection, but use different ones according to what I want. As follows;
Sigma 10-20mm. Great for night star shots, and for things like museums where you cannot get far enough back with the standard type lens to get it all in. Museums normally put you quite close to displays, and a 17mm start is too narrow for one shot;
Canon 17-55mm F2.8 IS, my favourite lens. Sharp as a tack, quick focussing, great IS. Absolutely the best indoor lens there is, and only comes off if too long, where I need the 10-20mm Sigma. I have got shots as low as 1/5th sec hand held thathave come out way better than expected when shooting in poor light (Nocturnal houses, AQUA centres etc.) and where flash and tripods are banned. If this baby can't get you the shot, then nothing will. Not only great on the IS, some of my shots have been at full zoom of 55mm at 1/5th of a sec, and not been throw-outs. I just cannot praise it highly enough.
Canon 18-200mm IS lens. Came with the 50D, and a great travel lens. Also when in dusty conditions or other places where changing a lens is avoided at all costs. Reasonable optics, reasonable focus speed, good IS. But a bit overpriced.
Canon 55-250mm IS. This is a great value for money lens, and is the first choice when needing a bit more than 55mm. Will choose it over the 18-200 any day for IQ.
Canon 100-400 L IS. Unsurpassed as an outdoors/BIF lens etc. As soon as I get to 100mm or more, this lens is on. Early ones were sometimes soft at long zooms, but no-one I have heard has got a soft one in the last few years. Mine's sharp even at F5.6 and 400mm zoom. probably my most mounted lens after the 17-55mm one.
If finances allow later, for shooting indoor sport, I'd add the 70-200mm F2.8 IS. I've shot with one and they are amazing, but a hefty price tag too. But I think this lens is more for those who are selling pic's, and want to earn money from them. I'm over $13K in 2 Camera bags as an amateur, so that's pretty much as much as I can justify. But everyone has a different budget.
--
The Aussie Viking