It's gratifying to see that almost everyone responding to this thread never makes bad decisions or has regrets about a purchase. Seems like this has rapidly degenerated to a piling on session with a lot of unnecessary personal attacks.
GAS is a powerful motivator and the excitement that surrounds the launch of a new and highly anticipated camera can be pretty contagious. What's more, some of the enhancements in the XP2 (new sensor, joystick, fantastic reports on IQ... etc.) are all things that many of us in X-T1 land would really envy and desire. So I totally "get" why the OP might have felt compelled to pick up an X-Pro2, even with the possibility of an X-T2 not too far off. Renting might have been a better approach, but that may not have seemed that feasible given strong initial demand, and there is good old GAS as an additional motivator.
At least in my case, being retired has now forced me to think through my equipment purchases a lot more, but I have to admit to having been totally sucked into the excitement of new camera introductions years ago and riding the DSLR upgrade curve for quite some time (Canon 10D ->20D -> 30D -> 40D -> (finally got some sanity and skipped the 50D) -> 7D. Held on to that for 4 years (unbelievable), then moved lock, stock and barrel to Fuji.
I happen to agree with the OP's concerns and his concerns among others are what would keep me from even considering an X-Pro2, regardless of all the cool upgrades. But in my GAS-a-holic days, I'd have to admit that I'd be awfully tempted by the new features. I think it might be wise to spend a minute in someone else's shoes before passing judgment.